LDAP: Only set password if user exists

neuf_ldap/utils.py

@@ -34,13 +34,13 @@ def set_ldap_password(username, raw_password):
 def ldap_user_group_exists(username):
     from neuf_ldap.models import LdapGroup
 
-    return len(LdapGroup.objects.filter(name=username)) != 0
+    return LdapGroup.objects.filter(name=username).exists()
 
 
 def ldap_username_exists(username):
     from neuf_ldap.models import LdapUser
 
-    return len(LdapUser.objects.filter(username=username)) != 0
+    return LdapUser.objects.filter(username=username).exists()
 
 
 def create_ldap_user(user, dry_run=False):

neuf_userinfo/forms.py

@@ -42,7 +42,8 @@ class NeufSetPasswordForm(SetPasswordForm):
 
         # Active services
         set_radius_password(username, password)  # creates user if non-existant
-        set_ldap_password(username, password)
+        if ldap_username_exists(username):
+            set_ldap_password(username, password)
 
         if has_kerberos_principal(username):
             set_kerberos_password(username, password)