From c829a39c2f1bfef60cad16b08a60f35d01036529 Mon Sep 17 00:00:00 2001
From: Jonas Braathen <jonas@ponas.no>
Date: Tue, 6 Aug 2024 15:24:54 +0200
Subject: [PATCH] move event filter reset button, don't hide filters when
 resetting

---
 web/src/components/events/EventContainer.tsx | 10 ++++++++++
 web/src/components/events/EventFilter.tsx    | 20 +-------------------
 2 files changed, 11 insertions(+), 19 deletions(-)

diff --git a/web/src/components/events/EventContainer.tsx b/web/src/components/events/EventContainer.tsx
index 98fe830..3266467 100644
--- a/web/src/components/events/EventContainer.tsx
+++ b/web/src/components/events/EventContainer.tsx
@@ -54,6 +54,10 @@ export const EventContainer = ({
     setVenue(null);
   };
 
+  const onResetFilters = (e: React.MouseEvent<HTMLButtonElement>) => {
+    resetFilters();
+  };
+
   /* Allow filtering on all categories that are configured to be shown */
   const filterableCategories = eventCategories.filter((x) => x.showInFilters);
 
@@ -139,6 +143,12 @@ export const EventContainer = ({
             <span>Vis kalender</span>
             <Icon type="calendar" />
           </button>
+          {(category || organizer || venue) && (
+            <button onClick={onResetFilters} className="button tertiary">
+              <span>Vis alle</span>
+              <Icon type="noFilter" />
+            </button>
+          )}
           <button onClick={toggleFilter} className="button tertiary">
             <span>Filter</span>
             <Icon type="filter" />
diff --git a/web/src/components/events/EventFilter.tsx b/web/src/components/events/EventFilter.tsx
index 04d83b0..fb80d4b 100644
--- a/web/src/components/events/EventFilter.tsx
+++ b/web/src/components/events/EventFilter.tsx
@@ -14,8 +14,6 @@ export const EventFilter = ({
   venues,
   activeVenue,
   setVenue,
-  resetFilters,
-  toggleVisibility,
   isVisible,
 }: {
   eventCategories: EventCategory[];
@@ -27,8 +25,6 @@ export const EventFilter = ({
   venues: VenueFragment[];
   activeVenue: string | null;
   setVenue: (slug: string | null) => void;
-  resetFilters: () => void;
-  toggleVisibility: () => void;
   isVisible: boolean;
 }) => {
   const onOrganizerSelect = (e: React.ChangeEvent<HTMLSelectElement>) => {
@@ -39,10 +35,6 @@ export const EventFilter = ({
     const venue = e.target.value;
     setVenue(venue === "" ? null : venue);
   };
-  const onResetFilters = (e: React.MouseEvent<HTMLButtonElement>) => {
-    resetFilters();
-    toggleVisibility();
-  };
 
   return (
     <div className={styles.eventFilter} data-show={isVisible}>
@@ -53,9 +45,7 @@ export const EventFilter = ({
             {eventCategories
               .filter((x) => x.showInFilters)
               .map((category) => (
-                <li
-                  key={category.slug}
-                >
+                <li key={category.slug}>
                   <button
                     className="button toggler"
                     data-active={activeCategory === category.slug}
@@ -105,14 +95,6 @@ export const EventFilter = ({
             ))}
           </select>
         </div>
-        {(activeCategory || activeOrganizer || activeVenue) && (
-          <div className={styles.filterItem}>
-            <button onClick={onResetFilters} className="button tertiary">
-              <span>Vis alle</span>
-              <Icon type="noFilter" />
-            </button>
-          </div>
-        )}
       </div>
     </div>
   );