From d3fdc28946406619d987ef048603ad48fea9df0e Mon Sep 17 00:00:00 2001
From: Nikolai Kristiansen <nikolaik@gmail.com>
Date: Tue, 12 Aug 2014 10:13:47 +0200
Subject: [PATCH] Fix a notice, log errors, adds manual as valid source

---
 sms/register.php            | 2 ++
 snapporder/activate.php     | 1 +
 snapporder/api/register.php | 8 +++++---
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/sms/register.php b/sms/register.php
index 12f58c2..4d10582 100644
--- a/sms/register.php
+++ b/sms/register.php
@@ -30,6 +30,7 @@ $lastname = "";
 $email = "";
 $activation_code = "";
 $phone = "";
+$validation_errors = "";
 
 if( isset($_GET['n']) ) {
     // phone
@@ -70,6 +71,7 @@ if( isset($_POST['submit']) ) {
             die();
         } catch(InsideDatabaseException $e) {
             echo $e->getMessage();
+            error_log($e->getMessage());
             die();
         }
     }
diff --git a/snapporder/activate.php b/snapporder/activate.php
index 0d7a908..2c66199 100644
--- a/snapporder/activate.php
+++ b/snapporder/activate.php
@@ -84,6 +84,7 @@ if( isset($_POST['submit']) ) {
             die();
         } catch(InsideDatabaseException $e) {
             echo $e->getMessage();
+            error_log($e->getMessage());
             die();
         }
     }
diff --git a/snapporder/api/register.php b/snapporder/api/register.php
index 806bf5c..86e74ac 100644
--- a/snapporder/api/register.php
+++ b/snapporder/api/register.php
@@ -11,7 +11,7 @@
  *   "lastname": "Hansen",
  *   "email": "jon@uio.no",
  *   "purchased": "2004-02-12"    // optional, format: ISO-8601 date
- *   "source": "snapporder_sms"   // optional, possible values: "snapporder" or "snapporder_sms"
+ *   "source": "snapporder"   // optional, possible values: "snapporder", "sms" or "manual"
  *   "membership_trial": "buddy"  // optional, gives free membership in autumn, possible value: "buddy"
  * }
  *
@@ -38,7 +38,7 @@
  *   "phone": "+4742345678",
  *   "purchased": "2004-02-12"   // optional, format: ISO-8601 date
  *   "type": "renewal"           // optional, possible value: "renewal"
- *   "source": "snapporder_sms"  // optional, possible values: "snapporder" or "snapporder_sms"
+ *   "source": "snapporder"  // optional, possible values: "snapporder", "sms" or "manual"
  * }
  *
  */
@@ -178,7 +178,7 @@ if( isset($data['purchased']) ) {
 }
 
 /* Validate optional source */
-if( isset($data['source']) && !in_array($data['source'], array('snapporder', 'snapporder_sms')) ) {
+if( isset($data['source']) && !in_array($data['source'], array('snapporder', 'sms', 'manual')) ) {
     set_response_code(400);
     echo $crypt->json_encode_and_encrypt(array('error' => 'Invalid value in field source: '.$data['source']));
     die();
@@ -201,6 +201,7 @@ try {
 } catch(InsideDatabaseException $e) {
     set_response_code(500);
     echo $crypt->json_encode_and_encrypt(array('error' => 'db_error', 'error_message' => $e->getMessage()));
+    error_log($e->getMessage());
     die();
 }
 
@@ -211,6 +212,7 @@ try {
 } catch(InsideDatabaseException $e) {
     set_response_code(500);
     echo $crypt->json_encode_and_encrypt(array('error' => 'db_error', 'error_message' => $e->getMessage()));
+    error_log($e->getMessage());
     die();
 }